Skip to content

Fixed SearchEngineProviderServiceTest.PRE_InvalidPrivateSearchProvide… #25874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

simonhong
Copy link
Member

…rRestoreTest

fix brave/brave-browser#41470

TemplateURLService should be loaded before setting prefs::kSyncedDefaultPrivateSearchProviderGUID prefs.

Resolves

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

…rRestoreTest

fix brave/brave-browser#41470

TemplateURLService should be loaded before setting
prefs::kSyncedDefaultPrivateSearchProviderGUID prefs.
@simonhong simonhong self-assigned this Oct 8, 2024
@simonhong simonhong requested a review from bridiver October 8, 2024 10:47
@simonhong simonhong marked this pull request as ready for review October 8, 2024 12:56
@simonhong simonhong merged commit 3a16879 into master Oct 10, 2024
18 checks passed
@simonhong simonhong deleted the fix_search_engine_provider_service_test_race_condition branch October 10, 2024 00:43
@github-actions github-actions bot added this to the 1.73.x - Nightly milestone Oct 10, 2024
@brave-builds
Copy link
Collaborator

Released in v1.73.2

@bsclifton bsclifton modified the milestones: 1.73.x - Nightly, 1.74.x - Nightly Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SearchEngineProviderServiceTest.PRE_InvalidPrivateSearchProviderRestoreTest failure
4 participants